From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brijesh Singh Subject: Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) Date: Tue, 6 Feb 2018 19:07:20 -0600 Message-ID: <314f8f96-5d92-0d2a-39ec-c7665ef2b738@amd.com> References: <20180129174132.108925-1-brijesh.singh@amd.com> <5A79CF18020000480006831E@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: brijesh.singh@amd.com, Thomas.Lendacky@amd.com, Stefan Hajnoczi , peter.maydell@linaro.org, richard.henderson@linaro.org, "Dr. David Alan Gilbert" , ehabkost@redhat.com, "Michael S. Tsirkin" , Paolo Bonzini , kvm@vger.kernel.org, edgar.iglesias@xilinx.com To: Bruce Rogers , qemu-devel@nongnu.org Return-path: Received: from mail-sn1nam02on0065.outbound.protection.outlook.com ([104.47.36.65]:17123 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754194AbeBGBH3 (ORCPT ); Tue, 6 Feb 2018 20:07:29 -0500 In-Reply-To: <5A79CF18020000480006831E@prv-mh.provo.novell.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 2/6/18 9:51 AM, Bruce Rogers wrote: >>>> On 1/29/2018 at 10:41 AM, wrote: >> This patch series provides support for AMD's new Secure Encrypted >> Virtualization (SEV) feature. >> >> SEV is an extension to the AMD‑V architecture which supports running >> multiple VMs under the control of a hypervisor. The SEV feature allows >> the memory contents of a virtual machine (VM) to be transparently encrypted >> with a key unique to the guest VM. The memory controller contains a >> high performance encryption engine which can be programmed with multiple >> keys for use by a different VMs in the system. The programming and >> management of these keys is handled by the AMD Secure Processor firmware >> which exposes a commands for these tasks. >> >> The KVM SEV patch series introduced a new ioctl (KVM_MEMORY_ENCRYPTION_OP) >> which is used by qemu to issue the SEV commands to assist performing >> common hypervisor activities such as a launching, running, snapshooting, >> migration and debugging guests. >> > As for the reported failure to build on non-x86 hosts, eg: > ... > LINK i386-softmmu/qemu-system-i386 > target/i386/helper.o: In function `get_me_mask': > /var/tmp/patchew-tester-tmp-hek3vjny/src/target/i386/helper.c:735: undefined reference to `kvm_arch_get_supported_cpuid' > target/i386/monitor.o: In function `get_me_mask': > /var/tmp/patchew-tester-tmp-hek3vjny/src/target/i386/monitor.c:71: undefined reference to `kvm_arch_get_supported_cpuid' > > ... I've looked at that a bit and find that in target/i386/kvm-stub.c, if we get rid of > the #ifndef __OPTIMIZE__ it then builds ok. I'm not sure if the guarding done there > with the check for __OPTIMIZE__ is a relic that no longer applies given how qemu > currently builds, but at least it's something to look at. Thanks for looking Bruce. I have reworked code a bit and that should fix this build error. I will be posting patches soon for review. > Bruce >