From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH 15/15] MIPS: paravirt: Provide _machine_halt function to exit VM on shutdown of guest Date: Thu, 29 May 2014 00:18:26 +0100 Message-ID: <3222538.mhZJm7FgWx@radagast> References: <1400597236-11352-1-git-send-email-andreas.herrmann@caviumnetworks.com> <537CADD1.5020006@imgtec.com> <20140528220418.GA6335@alberich> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Andreas Herrmann , David Daney , Ralf Baechle , kvm@vger.kernel.org To: linux-mips@linux-mips.org Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:40128 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbaE1XSc (ORCPT ); Wed, 28 May 2014 19:18:32 -0400 Received: by mail-wi0-f177.google.com with SMTP id f8so4621345wiw.16 for ; Wed, 28 May 2014 16:18:31 -0700 (PDT) In-Reply-To: <20140528220418.GA6335@alberich> Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 29 May 2014 00:04:18 Andreas Herrmann wrote: > On Wed, May 21, 2014 at 02:44:49PM +0100, James Hogan wrote: > > On 20/05/14 15:47, Andreas Herrmann wrote: > > > Signed-off-by: Andreas Herrmann > > > > Does it make sense to provide a _machine_restart too? > > Hmm, I've not seen a real need for this so far. > (Halting the guest and relaunching it from the shell with lkvm was fast > enough for my tests ;-) > > But it's worth to get it working. I might be wrong but I think that > this requires lkvm changes to actually handle the reboot. Fair enough. No point implementing something that can't be used/tested yet. If QEMU gets support for paravirt, it can be done then. Cheers James