From: Reinette Chatre <reinette.chatre@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: <kvm@vger.kernel.org>, <eric.auger@redhat.com>, <clg@redhat.com>,
<linux-kernel@vger.kernel.org>, <kevin.tian@intel.com>
Subject: Re: [PATCH 3/7] vfio: Introduce interface to flush virqfd inject workqueue
Date: Fri, 8 Mar 2024 12:46:10 -0800 [thread overview]
Message-ID: <346188f0-5f87-4ee7-971b-a6832dfbd5eb@intel.com> (raw)
In-Reply-To: <20240306211445.1856768-4-alex.williamson@redhat.com>
Hi Alex,
On 3/6/2024 1:14 PM, Alex Williamson wrote:
> In order to synchronize changes that can affect the thread callback,
> introduce an interface to force a flush of the inject workqueue. The
> irqfd pointer is only valid under spinlock, but the workqueue cannot
> be flushed under spinlock. Therefore the flush work for the irqfd is
> queued under spinlock. The vfio_irqfd_cleanup_wq workqueue is re-used
> for queuing this work such that flushing the workqueue is also ordered
> relative to shutdown.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
Thank you very much.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2024-03-08 20:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 21:14 [PATCH 0/7] vfio: Interrupt eventfd hardening Alex Williamson
2024-03-06 21:14 ` [PATCH 1/7] vfio/pci: Disable auto-enable of exclusive INTx IRQ Alex Williamson
2024-03-07 8:28 ` Tian, Kevin
2024-03-07 20:17 ` Alex Williamson
2024-03-08 7:20 ` Tian, Kevin
2024-03-07 8:39 ` Tian, Kevin
2024-03-07 20:23 ` Alex Williamson
2024-03-08 7:23 ` Tian, Kevin
2024-03-08 17:03 ` Alex Williamson
2024-03-08 17:05 ` Jason Gunthorpe
2024-03-06 21:14 ` [PATCH 2/7] vfio/pci: Lock external INTx masking ops Alex Williamson
2024-03-07 8:37 ` Tian, Kevin
2024-03-07 20:21 ` Alex Williamson
2024-03-08 7:17 ` Tian, Kevin
2024-03-08 20:45 ` Reinette Chatre
2024-03-06 21:14 ` [PATCH 3/7] vfio: Introduce interface to flush virqfd inject workqueue Alex Williamson
2024-03-07 8:58 ` Tian, Kevin
2024-03-08 20:46 ` Reinette Chatre [this message]
2024-03-06 21:14 ` [PATCH 4/7] vfio/pci: Create persistent INTx handler Alex Williamson
2024-03-08 7:14 ` Tian, Kevin
2024-03-08 20:46 ` Reinette Chatre
2024-03-06 21:14 ` [PATCH 5/7] vfio/platform: Disable virqfds on cleanup Alex Williamson
2024-03-08 7:16 ` Tian, Kevin
2024-03-08 18:09 ` Alex Williamson
2024-03-06 21:14 ` [PATCH 6/7] vfio/platform: Create persistent IRQ handlers Alex Williamson
2024-03-06 21:14 ` [PATCH 7/7] vfio/fsl-mc: Block calling interrupt handler without trigger Alex Williamson
2024-03-07 15:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346188f0-5f87-4ee7-971b-a6832dfbd5eb@intel.com \
--to=reinette.chatre@intel.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox