Re: [PATCH 01/26] drm/xe/pf: Remove GuC version check for migration support

Michal Wajdeczko
2025-10-12T18:32:17Z

On 10/11/2025 9:38 PM, Michał Winiarski wrote:
> Since commit 4eb0aab6e4434 ("drm/xe/guc: Bump minimum required GuC
> version to v70.29.2"), the minimum GuC version required by the driver
> is v70.29.2, which should already include everything that we need for
> migration.
> Remove the version check.
>
> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
> index 44cc612b0a752..a5bf327ef8889 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c
> @@ -384,9 +384,6 @@ ssize_t xe_gt_sriov_pf_migration_write_guc_state(struct xe_gt *gt, unsigned int
>
> static bool pf_check_migration_support(struct xe_gt *gt)
> {
> - /* GuC 70.25 with save/restore v2 is required */
> - xe_gt_assert(gt, GUC_FIRMWARE_VER(&gt->uc.guc) >= MAKE_GUC_VER(70, 25, 0));
> -

alternatively we can move this assert to guc_action_vf_save_restore()
to double check we try that on older firmware, but either way,

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> /* XXX: for now this is for feature enabling only */
> return IS_ENABLED(CONFIG_DRM_XE_DEBUG);
> }