From: Thomas Huth <thuth@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>,
Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com>
Cc: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3 1/2] s390x: Add specification exception test
Date: Wed, 27 Oct 2021 14:08:10 +0200 [thread overview]
Message-ID: <34a47a4e-0176-902e-c458-9e532cdb9fcb@redhat.com> (raw)
In-Reply-To: <20211026154113.1a9ab666@p-imbrenda>
On 26/10/2021 15.41, Claudio Imbrenda wrote:
> On Tue, 26 Oct 2021 14:00:31 +0200
> Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com> wrote:
[...]
>>> since you're ignoring the return value, can't you hardcode r6, and mark
>>> it (and r7) as clobbered? like:
>>> "lpq 6, %[bad]"
>>> : : [bad] "T"(words[1])
>>> : "%r6", "%r7"
>>>
>> Ok, btw. is there a reason bare register numbers seem to be more common
>> compared to %%rN ?
>
> I don't know, I guess laziness?
FWIW, older versions of Clang do not support bare register numbers on s390x,
so it's better to use %%rN, AFAIK...
OTOH, we cannot compile the kvm-unit-tests with older versions of Clang
anyway, so it likely doesn't matter here.
Thomas
next prev parent reply other threads:[~2021-10-27 12:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 12:01 [kvm-unit-tests PATCH v3 0/2] Add specification exception tests Janis Schoetterl-Glausch
2021-10-22 12:01 ` [kvm-unit-tests PATCH v3 1/2] s390x: Add specification exception test Janis Schoetterl-Glausch
2021-10-25 17:17 ` Claudio Imbrenda
2021-10-26 12:00 ` Janis Schoetterl-Glausch
2021-10-26 13:41 ` Claudio Imbrenda
2021-10-27 10:00 ` Janis Schoetterl-Glausch
2021-10-27 12:08 ` Thomas Huth [this message]
2021-10-22 12:01 ` [kvm-unit-tests PATCH v3 2/2] s390x: Test specification exceptions during transaction Janis Schoetterl-Glausch
2021-10-25 17:30 ` Claudio Imbrenda
2021-10-25 18:28 ` Christian Borntraeger
2021-10-26 14:22 ` Janis Schoetterl-Glausch
2021-10-26 14:55 ` Claudio Imbrenda
2021-10-27 10:05 ` Janis Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a47a4e-0176-902e-c458-9e532cdb9fcb@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=scgl@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox