From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A21C0032E for ; Thu, 26 Oct 2023 01:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbjJZBGx (ORCPT ); Wed, 25 Oct 2023 21:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJZBGv (ORCPT ); Wed, 25 Oct 2023 21:06:51 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37E06AC; Wed, 25 Oct 2023 18:06:49 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59ADD2F4; Wed, 25 Oct 2023 18:07:30 -0700 (PDT) Received: from [10.57.2.160] (unknown [10.57.2.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EDFC3F762; Wed, 25 Oct 2023 18:06:46 -0700 (PDT) Message-ID: <34e70291-4657-89ae-4e61-5980bb8ea3ab@arm.com> Date: Thu, 26 Oct 2023 02:06:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/5] KVM: selftests: Generate sysreg-defs.h and add to include path Content-Language: en-US To: Oliver Upton Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Mark Brown , Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Marc Zyngier , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra References: <20231011195740.3349631-1-oliver.upton@linux.dev> <20231011195740.3349631-4-oliver.upton@linux.dev> From: Aishwarya TCV In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 25/10/2023 20:07, Oliver Upton wrote: > On Wed, Oct 25, 2023 at 10:02:36AM +0100, Aishwarya TCV wrote: >> On 11/10/2023 20:57, Oliver Upton wrote: >>> Start generating sysreg-defs.h for arm64 builds in anticipation of >>> updating sysreg.h to a version that depends on it. >>> >>> Reviewed-by: Mark Brown >>> Signed-off-by: Oliver Upton >>> --- >>> tools/testing/selftests/kvm/Makefile | 23 ++++++++++++++++++++--- >>> 1 file changed, 20 insertions(+), 3 deletions(-) >>> >> >> Hi Oliver, >> >> >> Currently when building kselftest against next-master with arm64 arch >> and defconfig+kselftest-kvm “make[4]: *** [Makefile:26: prepare] Error >> 2” is observed. > > Looks like we're descending into tools/arch/arm64/tools/ w/ > $(srctree) == ".", which I believe is coming from the top makefile. The > following diff fixes it for me, care to give it a go? > > diff --git a/tools/arch/arm64/tools/Makefile b/tools/arch/arm64/tools/Makefile > index f867e6036c62..7f64b8bb5107 100644 > --- a/tools/arch/arm64/tools/Makefile > +++ b/tools/arch/arm64/tools/Makefile Confirming that the patch worked fine in the testing. Attached the log below: make[4]: Entering directory '/linux/tools/testing/selftests/kvm' Makefile:270: warning: overriding recipe for target '/linux/build-arm64/kselftest/kvm/get-reg-list' Makefile:265: warning: ignoring old recipe for target '/linux/build-arm64/kselftest/kvm/get-reg-list' make -C ../../../../tools/arch/arm64/tools/ make[5]: Entering directory '/linux/tools/arch/arm64/tools' GEN /linux/tools/arch/arm64/include/generated/asm/sysreg-defs.h make[5]: Leaving directory '/linux/tools/arch/arm64/tools' Thanks, Aishwarya