From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>, Cathy Avery <cavery@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
vkuznets@redhat.com, wei.huang2@amd.com
Subject: Re: [PATCH] KVM: nSVM: Optimize L12 to L2 vmcb.save copies
Date: Tue, 2 Mar 2021 15:20:11 +0100 [thread overview]
Message-ID: <35b73239-56bd-8979-d9aa-1571eb73e94d@redhat.com> (raw)
In-Reply-To: <YD2N/4sDKS4RJdlR@google.com>
On 02/03/21 01:59, Sean Christopherson wrote:
>> + svm->vmcb->save.cr2 = svm->vcpu.arch.cr2 = vmcb12->save.cr2;
> Same question for VMCB_CR2.
Besides the question of how much AMD processors actually use the clean
bits (a quick test suggests "not much"), in this specific case I suspect
that the check would be more expensive than the savings from a memory load.
Paolo
prev parent reply other threads:[~2021-03-02 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 20:08 [PATCH] KVM: nSVM: Optimize L12 to L2 vmcb.save copies Cathy Avery
2021-03-02 0:59 ` Sean Christopherson
2021-03-02 12:56 ` Cathy Avery
2021-03-02 14:18 ` Paolo Bonzini
2021-03-02 14:20 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b73239-56bd-8979-d9aa-1571eb73e94d@redhat.com \
--to=pbonzini@redhat.com \
--cc=cavery@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox