From mboxrd@z Thu Jan  1 00:00:00 1970
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Subject: Re: [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before
 enabling AVIC
Date: Thu, 14 Sep 2017 08:23:48 -0700
Message-ID: <3603043c-964f-d10c-8cc0-fa3476e3bbb5@amd.com>
References: <1505230962-86304-1-git-send-email-suravee.suthikulpanit@amd.com>
 <1505230962-86304-4-git-send-email-suravee.suthikulpanit@amd.com>
 <20170914152031.GA23415@flask>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        pbonzini@redhat.com, joro@8bytes.org
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20170914152031.GA23415@flask>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Radim,

On 9/14/17 08:20, Radim Krčmář wrote:
>> @@ -1594,6 +1593,12 @@ static int avic_init_vcpu(struct vcpu_svm *svm)
>>  	if (!avic)
>>  		return 0;
>>
>> +	if (!kvm_vcpu_apicv_active(&svm->vcpu)) {
>> +		pr_debug("%s: Disable AVIC due to non-split irqchip.\n",
>> +			      __func__);
> We need to have an extra condition just because of this print ...
> I removed the print altogether when applying -- I thought more about
> that and it was aimed at people who wonder why AVIC was suddenly
> disabled and it's unlikely that they will enable a debug message without
> already knowing the reason,

Make sense. Thanks.

>
> thanks.
>
>> @@ -4388,7 +4393,7 @@ static void svm_set_virtual_x2apic_mode(struct kvm_vcpu *vcpu, bool set)
>>
>>  static bool svm_get_enable_apicv(struct kvm_vcpu *vcpu)
>>  {
> A close contender was pr_info_once() here:
>
> 	if (avic && !irqchip_split(vcpu->kvm))
> 		pr_info_once(...)
>

Looks good.

Thanks,
Suravee