From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F89C433E6 for ; Mon, 22 Feb 2021 20:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEDD064E2E for ; Mon, 22 Feb 2021 20:17:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233418AbhBVURT (ORCPT ); Mon, 22 Feb 2021 15:17:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbhBVURR (ORCPT ); Mon, 22 Feb 2021 15:17:17 -0500 X-Greylist: delayed 707 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 22 Feb 2021 12:16:37 PST Received: from zero.eik.bme.hu (zero.eik.bme.hu [IPv6:2001:738:2001:2001::2001]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACD78C061574 for ; Mon, 22 Feb 2021 12:16:37 -0800 (PST) Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 02F4C7462D3; Mon, 22 Feb 2021 21:03:56 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id B583A7462BD; Mon, 22 Feb 2021 21:03:55 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id B37E474581E; Mon, 22 Feb 2021 21:03:55 +0100 (CET) Date: Mon, 22 Feb 2021 21:03:55 +0100 (CET) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= cc: qemu-devel@nongnu.org, Peter Maydell , Huacai Chen , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , Aleksandar Rikalo , Jiaxun Yang , Stefano Stabellini , "Michael S. Tsirkin" , Halil Pasic , Christian Borntraeger , =?ISO-8859-15?Q?Herv=E9_Poussineau?= , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Aurelien Jarno Subject: Re: [PATCH v2 04/11] hw/arm: Restrit KVM to the virt & versal machines In-Reply-To: <20210219173847.2054123-5-philmd@redhat.com> Message-ID: <36692cea-e747-b054-51ff-bbcfbbdd4151@eik.bme.hu> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-5-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-317435051-1614024235=:60531" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-317435051-1614024235=:60531 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Fri, 19 Feb 2021, Philippe Mathieu-Daudé wrote: > Restrit KVM to the following ARM machines: Typo: "Restrict" (also in patch title). Regards, BALATON Zoltan > - virt > - xlnx-versal-virt > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c | 5 +++++ > hw/arm/xlnx-versal-virt.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 371147f3ae9..8e9861b61a9 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -2527,6 +2527,10 @@ static HotplugHandler *virt_machine_get_hotplug_handler(MachineState *machine, > return NULL; > } > > +static const char *const valid_accels[] = { > + "tcg", "kvm", "hvf", NULL > +}; > + > /* > * for arm64 kvm_type [7-0] encodes the requested number of bits > * in the IPA address space > @@ -2582,6 +2586,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) > mc->cpu_index_to_instance_props = virt_cpu_index_to_props; > mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); > mc->get_default_cpu_node_id = virt_get_default_cpu_node_id; > + mc->valid_accelerators = valid_accels; > mc->kvm_type = virt_kvm_type; > assert(!mc->get_hotplug_handler); > mc->get_hotplug_handler = virt_machine_get_hotplug_handler; > diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c > index 8482cd61960..d424813cae1 100644 > --- a/hw/arm/xlnx-versal-virt.c > +++ b/hw/arm/xlnx-versal-virt.c > @@ -610,6 +610,10 @@ static void versal_virt_machine_instance_init(Object *obj) > { > } > > +static const char *const valid_accels[] = { > + "tcg", "kvm", NULL > +}; > + > static void versal_virt_machine_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); > @@ -621,6 +625,7 @@ static void versal_virt_machine_class_init(ObjectClass *oc, void *data) > mc->default_cpus = XLNX_VERSAL_NR_ACPUS; > mc->no_cdrom = true; > mc->default_ram_id = "ddr"; > + mc->valid_accelerators = valid_accels; > } > > static const TypeInfo versal_virt_machine_init_typeinfo = { > --3866299591-317435051-1614024235=:60531--