From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B88C4221578 for ; Tue, 24 Jun 2025 10:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760217; cv=none; b=EAXZDJXhGPP/OIdtV2oUHWOo7u3vRvic7G/1oiPi0N8BAc6Cw277qfA024NLsjqWXx2z3Z/JKCggjSE5BW0BrMePSgXRmUIi2ptILTLlWHLUP2fOOO2/B3dGBuK3o8EBeL8ggMiSG0r4gini2FlB9bWKinUBkIKxdEo5EAsz80g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760217; c=relaxed/simple; bh=9c2225T6/GQjHawVxpn8l0ObvfonYc83pMHDTjwjvaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EkEa9BTe3/vWWRMYsfjbusp2vYASPLvbqq/rfjHaLZbktcZ8av7B9fwXwa1Cc5NMmuBK83uTVXgszA/zFgXxGq8XZb4412LAI+/+iykTzxJorzkLdXCRjWMGZbEY9cPWYkVEqMAS5/FhPhDnD9OXfWYxFD+veTVcAeZynr5Pjxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VWAYcJon; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VWAYcJon" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750760214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e8dNKC0X6bQu3TedhJQtwWZN5XrLmAV6V9h08RG7LQU=; b=VWAYcJonerx2I3pNQAHr1wKnEfYW7ta2qBD3uj6m5Ya65WAImdCUZ5WBOEb7fal0n3LM6x MrojhtlqoDLkwcV1L/XAAwFqhMgminfRRLDfpQNJM9abnIrFUvavxT0CbftltGMLQUyDNI Llp4w8hud1KnT2YY2TuWcIgFXkqMXJ4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-1ebU8xxVN-iDfliwosyysQ-1; Tue, 24 Jun 2025 06:16:53 -0400 X-MC-Unique: 1ebU8xxVN-iDfliwosyysQ-1 X-Mimecast-MFC-AGG-ID: 1ebU8xxVN-iDfliwosyysQ_1750760212 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4537f56ab74so1773425e9.3 for ; Tue, 24 Jun 2025 03:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750760212; x=1751365012; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e8dNKC0X6bQu3TedhJQtwWZN5XrLmAV6V9h08RG7LQU=; b=nuro8k/X0rET9/Yy9wfwpOasoCJK1gIsS0vrF+x0b7R9GQ8zOkuWoJUX+f+Z3aNr1d oTf5axys6qSduRnfvzJgGTxA/DDrV7fnUf2Ki9GRdLHUJrlfUPTe0vx5Z51ge7/fGHKp pgS0vGw4BiCoINKgNN/1a6vrxbQe6wrgYx3h8XIQFp9k20tUdzKkEZZaGQKGysEXWZRo 4N/Gx8r3PYxHb3WqwOvztxJCTSdFHlQL80Nm/XGfYN8QD0+qUOx/jzxxkxVM7mZlK+v/ BqQkui4LDo+VODO8Up5IrKMalfyfKnENoUZ1DQa8xWOS0g7ElhGEz+bIKyOZl6rHSCYU grHw== X-Gm-Message-State: AOJu0YxyjftmIJHaVNogzvN8c1uFXn6sG87U0rCm7U5pWueMmO5NE19V Ig2m3XKIxJKCuLDb7QmGN7+gSe7gdOyTyhxPbE7rQoiJL7gaNfIAQ/SSzBgZmzCwJpnWMO2LhOl zfWLQshTnARwMSwM5xMzf9/M5yXSeZwQtCHwT8oLPAxD+/4/TnquA7w== X-Gm-Gg: ASbGnctcyhReGXMzJUd3XpLwBPbIoWcoPR9/3SKEHx9/F0N5HVne798/DGTdVYR8zsV qGZ8r4sr/Mrykd0GM7mPPPjyZZ6jCpJOYHDkF1wt+nGFWZfhatjarzBzXKY6zRpHIsRFX1RRtAO oRsiXOIHlmdo0vl/yE189dHhx9nWsCFEt9ZOCQ47/0sbSiP+girZyqJOAJjcd8aeki2E3ifsSXE rQtrZwQCWaZP2f+zQEG+uBUWedf9tzClUvo552zFY2YWpjnCI/3hadeIrC+JzgA8JvO6q88DNu1 oUJLJvrV7MmlEb3qLryh3N1M+QVwHYvR0J2BXFuiApZBO8LaTKSqrMc= X-Received: by 2002:a05:600c:3b83:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453659ca16cmr163569925e9.14.1750760211657; Tue, 24 Jun 2025 03:16:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX0VcTFdiCx5jjkFEDifcYlhqbdTljgPaOYfiwFQrIaleDtnv03N4HZ/siPyrW8guste0lAg== X-Received: by 2002:a05:600c:3b83:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453659ca16cmr163569115e9.14.1750760211185; Tue, 24 Jun 2025 03:16:51 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453647f29bdsm137196525e9.18.2025.06.24.03.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 03:16:50 -0700 (PDT) Message-ID: <372bbfa5-1869-4bf2-9c16-0b828cdb86f5@redhat.com> Date: Tue, 24 Jun 2025 12:16:48 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 00/18] KVM: Mapping guest_memfd backed memory at the host for software protected VMs To: Fuad Tabba , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250611133330.1514028-1-tabba@google.com> <80e062dd-2445-45a6-ba4a-8f5fe3286909@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24.06.25 12:02, Fuad Tabba wrote: > Hi, > > Before I respin this, I thought I'd outline the planned changes for > V13, especially since it involves a lot of repainting. I hope that > by presenting this first, we could reduce the number of times I'll > need to respin it. > > In struct kvm_arch: add bool supports_gmem instead of renaming > has_private_mem > > The guest_memfd flag GUEST_MEMFD_FLAG_SUPPORT_SHARED should be > called GUEST_MEMFD_FLAG_MMAP > > The memslot internal flag KVM_MEMSLOT_SUPPORTS_GMEM_SHARED should be > called KVM_MEMSLOT_SUPPORTS_GMEM_MMAP > > kvm_arch_supports_gmem_shared_mem() should be called > kvm_arch_supports_gmem_mmap() > > kvm_gmem_memslot_supports_shared() should be called > kvm_gmem_memslot_supports_mmap() > > kvm_gmem_fault_shared(struct vm_fault *vmf) should be called > kvm_gmem_fault_user_mapping(struct vm_fault *vmf) > > The capability KVM_CAP_GMEM_SHARED_MEM should be called > KVM_CAP_GMEM_MMAP > > The Kconfig CONFIG_KVM_GMEM_SHARED_MEM should be called > CONFIG_KVM_GMEM_SUPPORTS_MMAP Works for me. > > Also, what (unless you disagree) will stay the same as V12: > > Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GMEM: Since private > implies gmem, and we will have additional flags for MMAP support Agreed. > > Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to > CONFIG_KVM_GENERIC_GMEM_POPULATE Agreed. > > Rename kvm_slot_can_be_private() to kvm_slot_has_gmem(): since > private does imply that it has gmem Right. It's a little more tricky in reality at least with this series: without in-place conversion, not all gmem can have private memory. But the places that check kvm_slot_can_be_private() likely only care about if this memslot is backed by gmem. Sean also raised a "kvm_is_memslot_gmem_only()", how did you end up calling that? -- Cheers, David / dhildenb