public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	Cai Huoqing <caihuoqing@baidu.com>
Cc: farman@linux.ibm.com, cohuck@redhat.com,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] vfio-pci/zdev: Remove repeated verbose license text
Date: Mon, 23 Aug 2021 12:26:38 -0400	[thread overview]
Message-ID: <376bdae4-b60b-25ad-86ba-d5ee918c2ef8@linux.ibm.com> (raw)
In-Reply-To: <20210823102056.49daf260.alex.williamson@redhat.com>

On 8/23/21 12:20 PM, Alex Williamson wrote:
> On Sun, 22 Aug 2021 12:35:00 +0800
> Cai Huoqing <caihuoqing@baidu.com> wrote:
> 
>> remove it because SPDX-License-Identifier is already used
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>> ---
>>   drivers/vfio/pci/vfio_pci_zdev.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
>> index 7b011b62c766..dfd8d826223d 100644
>> --- a/drivers/vfio/pci/vfio_pci_zdev.c
>> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
>> @@ -5,11 +5,6 @@
>>    * Copyright (C) IBM Corp. 2020.  All rights reserved.
>>    *	Author(s): Pierre Morel <pmorel@linux.ibm.com>
>>    *                 Matthew Rosato <mjrosato@linux.ibm.com>
>> - *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License version 2 as
>> - * published by the Free Software Foundation.
>> - *
>>    */
>>   #include <linux/io.h>
>>   #include <linux/pci.h>
> 
> The SPDX license for this file is actually GPL-2.0+ but the text here
> matches the more restrictive GPL-2.0.  I'm not a lawyer, but I'd expect
> the more restrictive license holds, so removing this text might
> actually change the license.  Should this also correct the SPDX
> license?  Perhaps we need clarification from the authors.  Thanks,
> 
> Alex
> 

Oh, good catch.  Yeah, I think if you're going to remove the verbose 
text, then the identifier should be 'SPDX-License-Identifier: 
GPL-2.0-only' to match the verbose text you're removing.

      reply	other threads:[~2021-08-23 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22  4:35 [PATCH] vfio-pci/zdev: Remove repeated verbose license text Cai Huoqing
2021-08-23 16:02 ` Matthew Rosato
2021-08-23 16:20 ` Alex Williamson
2021-08-23 16:26   ` Matthew Rosato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=376bdae4-b60b-25ad-86ba-d5ee918c2ef8@linux.ibm.com \
    --to=mjrosato@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=caihuoqing@baidu.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox