Re: [PATCH v15 04/41] KVM: x86: Introduce KVM_{G,S}ET_ONE_REG uAPIs support

Sean Christopherson
2025-09-17T13:14:48Z

On Tue, Sep 16, 2025, Binbin Wu wrote:
> On 9/13/2025 7:22 AM, Sean Christopherson wrote:
> > ---
> > Documentation/virt/kvm/api.rst | 6 +-
> > arch/x86/include/uapi/asm/kvm.h | 26 +++++++++
> > arch/x86/kvm/x86.c | 100 ++++++++++++++++++++++++++++++++
> > 3 files changed, 131 insertions(+), 1 deletion(-)
> [...]
> > +
> > +#define KVM_X86_REG_ENCODE(type, index) \
> Nit:
> Is it better to use KVM_X86_REG_ID so that when searching with the string
> non-case sensitively, the encoding and its structure can be related to each
> other?

I'm leaning _very_ slightly toward ENOCDE, but I am a-ok with ID too. Anyone
else have a preference? If not, I'll go with Binbinb's suggestion of ID.