From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v9 03/12] pci: Add 'extern' to public function declarations Date: Fri, 4 Nov 2016 08:36:05 +0100 Message-ID: <38d009b0-a8db-85fc-65ff-7bf58f31d2c1@redhat.com> References: <24c5c29c3bbd3fed9091efa8586c90068037f168.1478189002.git.agordeev@redhat.com> <20161103203023.GA22260@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Andrew Jones , Peter Xu To: Christoph Hellwig , Alexander Gordeev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165AbcKDHgJ (ORCPT ); Fri, 4 Nov 2016 03:36:09 -0400 In-Reply-To: <20161103203023.GA22260@infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: On 03.11.2016 21:30, Christoph Hellwig wrote: > Why? The extern keyword for function prototypes is a no-op. It's used in many of the kvm-unit-test header files already, so I guess the code looks a little bit more consistent this way. Thomas