From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies
Date: Tue, 19 Jun 2018 14:22:53 -0500
Message-ID: <3953c12f-c2fe-5d1d-bee2-ac9a230300b8@amd.com>
References: <1526915573-22917-1-git-send-email-Janakarajan.Natarajan@amd.com>
 <20180523144621.GB25143@pd.tnic>
 <CAFLxGvyxHU_Xahwdf=0TYx8Nems78TLioLZGGLTkxNGCgxT4Dg@mail.gmail.com>
 <4f565a11-9e99-b861-06d2-b42922e44c7a@amd.com>
 <20180619094658.GB31750@zn.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: brijesh.singh@amd.com,
        Richard Weinberger <richard.weinberger@gmail.com>,
        Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, x86@kernel.org,
        kvm <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, felix@feldspaten.org
To: Borislav Petkov <bp@suse.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180619094658.GB31750@zn.tnic>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Hi Boris,


On 06/19/2018 04:46 AM, Borislav Petkov wrote:
> On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote:
>> I think depends should look like this:
>>
>> config KVM_AMD_SEV
>>      def_bool y
>>      bool "AMD Secure Encrypted Virtualization (SEV) support"
>>      depends KVM_AMD && X86_64
>>      depends CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
> 
> CRYPTO_DEV_CCP_DD - this still doesn't belong here. KVM_AMD_SEV doesn't
> care about what kind of functionality the PSP needs to function and
> select it - it should only depend on a single symbol.
> 


It would be nice to have a single depends. But the main issue is, PSP 
support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). 
Hence KVM_AMD_SEV need to have some level of dependency with ccp driver. 
This is to ensure that the ccp was 'y' when kvm-amd=y for SEV to work.


> Now, you can add a separate CRYPTO .config item which collects all
> required functionality for SEV guests and have KVM_AMD_SEV depend
> on that. Or a similar solution. But not have KVM_AMD_SEV poke into
> CRYPTO...PSP dependencies because it doesn't need to know about it.
> 


I am sorry but I am not able to follow you on how creating a separate 
CRYPTO .config item will solve this problem. Creating a separate config 
will be useful if we are okay with calling 'select' from kvm (i.e if 
kvm-amd is 'y' then all the symbols from crypto will be 'y').

I looked at other drivers where they have similar situation and it seems 
like solution is same as what I have used above.


-Brijesh