From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirti Wankhede Subject: Re: [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices Date: Wed, 26 Oct 2016 20:31:02 +0530 Message-ID: <3f4d0fd5-89c2-d478-446c-8c21d7db51bd@nvidia.com> References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> <1476739332-4911-3-git-send-email-kwankhede@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Song, Jike" , "bjsdjshi@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" To: "Tian, Kevin" , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "kraxel@redhat.com" , "cjia@nvidia.com" Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:14383 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbcJZPBJ (ORCPT ); Wed, 26 Oct 2016 11:01:09 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: >> +static void vfio_mdev_release(void *device_data) >> +{ >> + struct mdev_device *mdev = device_data; >> + struct parent_device *parent = mdev->parent; >> + >> + if (parent->ops->release) > > likely() > >> + parent->ops->release(mdev); >> + >> + module_put(THIS_MODULE); >> +} >> + Thanks for pointing that out. Fixing this in next set of patch. Kirti