From: "Mika Penttilä" <mika.penttila@nextfour.com>
To: <rkagan@virtuozzo.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/5] kvm/x86: fix inversed check for async_pf MSR
Date: Fri, 2 Dec 2016 12:45:28 +0200 [thread overview]
Message-ID: <3f646c3d-5514-727c-4059-b417ff09886d@nextfour.com> (raw)
In-Reply-To: <a237e9b7-8155-5006-81b1-ac77a5efd13d@nextfour.com>
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index bf11fe4..14a46e9 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8402,7 +8402,7 @@ void kvm_arch_async_page_present(struct kvm_vcpu *vcpu,
> bool kvm_arch_can_inject_async_page_present(struct kvm_vcpu *vcpu)
> {
> if (!(vcpu->arch.apf.msr_val & KVM_ASYNC_PF_ENABLED))
> - return true;
> + return false;
>
>
Why do you make this change? I think kvm_arch_async_page_present() is not
ever called now and neither kvm_del_async_pf_gfn(vcpu, work->arch.gfn);
Even with !KVM_ASYNC_PF_ENABLED the pf is handled with the workqueue asynchronously.
>
>
>> else
>> return !kvm_event_needs_reinjection(vcpu) &&
> kvm_x86_ops->interrupt_allowed(vcpu);
>
--Mika
next parent reply other threads:[~2016-12-03 0:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a237e9b7-8155-5006-81b1-ac77a5efd13d@nextfour.com>
2016-12-02 10:45 ` Mika Penttilä [this message]
2016-12-02 12:05 ` [PATCH 1/5] kvm/x86: fix inversed check for async_pf MSR Roman Kagan
2016-12-02 15:24 Mika Penttilä
2016-12-02 17:02 ` Roman Kagan
-- strict thread matches above, loose matches on Subject: below --
2016-12-02 14:14 Mika Penttilä
2016-12-02 14:31 ` Roman Kagan
2016-12-02 8:47 [PATCH 0/5] kvm: avoid delaying async_pf ready delivery Roman Kagan
2016-12-02 8:47 ` [PATCH 1/5] kvm/x86: fix inversed check for async_pf MSR Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f646c3d-5514-727c-4059-b417ff09886d@nextfour.com \
--to=mika.penttila@nextfour.com \
--cc=kvm@vger.kernel.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox