From: Michael Ellerman <mpe@ellerman.id.au>
To: Sam bobroff <sam.bobroff@au1.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: kvm@vger.kernel.org, aik@ozlabs.ru, agraf@suse.de,
kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org, paulus@samba.org,
david@gibson.dropbear.id.au
Subject: Re: [1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM
Date: Fri, 8 Jul 2016 20:49:49 +1000 (AEST) [thread overview]
Message-ID: <3rmB8G0Wkxz9s9Z@ozlabs.org> (raw)
In-Reply-To: <741e7a7860e055603a311bcc6051bd88fdad1215.1467785081.git.sam.bobroff@au1.ibm.com>
On Wed, 2016-06-07 at 06:05:54 UTC, Sam bobroff wrote:
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 02416fe..06d79bc 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -588,6 +588,10 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> r = 1;
> break;
> #endif
> + case KVM_CAP_PPC_HTM:
> + r = cpu_has_feature(CPU_FTR_TM)
> + && is_kvmppc_hv_enabled(kvm);
I think it should be using CPU_FTR_TM_COMP.
And AFAICS you don't need to break that line.
cheers
next prev parent reply other threads:[~2016-07-08 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 6:05 [PATCH 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM Sam Bobroff
2016-07-06 11:05 ` Balbir Singh
2016-07-07 0:07 ` David Gibson
2016-07-08 10:49 ` Michael Ellerman [this message]
2016-07-19 3:23 ` [1/1] " Sam Bobroff
2016-07-19 9:24 ` Michael Ellerman
2016-07-19 9:24 ` Michael Ellerman
2016-07-19 9:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rmB8G0Wkxz9s9Z@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox