From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [kernel, v11, 03/10] powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal Date: Mon, 1 May 2017 12:58:51 +1000 (AEST) Message-ID: <3wGTdm05J0z9sND@ozlabs.org> References: <20170322042156.11756-4-aik@ozlabs.ru> Cc: kvm@vger.kernel.org, Alexey Kardashevskiy , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , David Gibson To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Return-path: Received: from ozlabs.org ([103.22.144.67]:52841 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059AbdEAC6x (ORCPT ); Sun, 30 Apr 2017 22:58:53 -0400 In-Reply-To: <20170322042156.11756-4-aik@ozlabs.ru> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2017-03-22 at 04:21:49 UTC, Alexey Kardashevskiy wrote: > At the moment iommu_table can be disposed by either calling > iommu_table_free() directly or it_ops::free(); the only implementation > of free() is in IODA2 - pnv_ioda2_table_free() - and it calls > iommu_table_free() anyway. > > As we are going to have reference counting on tables, we need an unified > way of disposing tables. > > This moves it_ops::free() call into iommu_free_table() and makes use > of the latter. The free() callback now handles only platform-specific > data. > > As from now on the iommu_free_table() calls it_ops->free(), we need > to have it_ops initialized before calling iommu_free_table() so this > moves this initialization in pnv_pci_ioda2_create_table(). > > This should cause no behavioral change. > > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson > Acked-by: Alex Williamson Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/11edf116e3a6352cfee6b1437d4160 cheers