From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4431CAB9 for ; Sun, 4 Aug 2024 08:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722759489; cv=none; b=qkPuF0RfI1XlZR41RKRslSnK3SWoyhh14VJGPwAk31buz8393U6QKMOEbBDjBhGCmwbIM/cdCqTC66BdYA1E6rLC8ajgO2G/qRbjcA5c2iPE7vEk4VZuO0KDcxob9eZTaQ9aYiJD1rdtymUfHXHHm7wWAs9dIy/zx3UELHg9KXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722759489; c=relaxed/simple; bh=ZYRZnef0yxaS5bV9saKBDKO14pgVNfmF9j2Bk9jzlJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GNPNswpeRy3DyCfnIZsMGLvO3y0+qwb7vUIaIcAoh8M4ab0Rnj9e9dyIzGljyOu9NSspLSeoHajjznzmEmRSfj1W/4ETwth8XSl0p5mMvCV8AQkdDr+8Yw7Z7pZiSYdv0JkDcIXoK/7kMdFHPbtR2IF9HPMekuXm7Q0DgQTxtKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ara32mym; arc=none smtp.client-ip=91.218.175.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ara32mym" Message-ID: <401bebca-9637-4626-901f-e46b2d058768@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1722759484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BR8nESmyux7KPrlPtWm/y86ziQt1dIfCuk1340ZZ33o=; b=ara32mymUPXn1tDy4bLqkZuYghp73ABnXKvkf214k9mbGPs4NlINmZEHazKOB+P84dAFc7 luVgeGbq8L7ea+dNC0SpntN3dVFowg3obE63kXZvD+oCKpN2lmqh2cwtEnOGvKKkYCyhrp kwRXT5GHI+wbOmfqrTETGUTO+1NIvio= Date: Sun, 4 Aug 2024 16:17:47 +0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ To: Takahiro Itazuri Cc: Paolo Bonzini , Jonathan Corbet , Dave Martin , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zulinx86@gmail.com, kvmarm@lists.linux.dev, Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , glider@google.com References: <20230606154628.95498-1-itazur@amazon.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zenghui Yu In-Reply-To: <20230606154628.95498-1-itazur@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT +Cc kvmarm people and the list ... On 2023/6/6 23:46, Takahiro Itazuri wrote: > Fixes the register ID of SPSR_FIQ. > > SPSR_FIQ is a 64-bit register and the 64-bit register size mask is > 0x0030000000000000ULL. > > Fixes: fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail") > Signed-off-by: Takahiro Itazuri ... since you're fixing the encoding of an *arm64* core register and the mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess this is the main reason why this patch has been blocked on the list for over a year, as pointed out recently by Alexander [*]. > > --- > Changes from v1 > - Add a description about the 64-bit register size mask in the commit > message. > - Link: https://lore.kernel.org/all/20230410121927.26953-1-itazur@amazon.com/ > > --- > Documentation/virt/kvm/api.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index a5c803f39832..65dad2581751 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -2535,7 +2535,7 @@ Specifically: > 0x6030 0000 0010 004a SPSR_ABT 64 spsr[KVM_SPSR_ABT] > 0x6030 0000 0010 004c SPSR_UND 64 spsr[KVM_SPSR_UND] > 0x6030 0000 0010 004e SPSR_IRQ 64 spsr[KVM_SPSR_IRQ] > - 0x6060 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] > + 0x6030 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] > 0x6040 0000 0010 0054 V0 128 fp_regs.vregs[0] [1]_ > 0x6040 0000 0010 0058 V1 128 fp_regs.vregs[1] [1]_ > ... The change itself looks reasonable. Thanks, Zenghui [*] https://lore.kernel.org/all/20240802132036.914457-1-glider@google.com