From: Thomas Huth <thuth@redhat.com>
To: Nadav Amit <namit@vmware.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] x86: Initialize segment selectors
Date: Wed, 24 Jun 2020 14:52:04 +0200 [thread overview]
Message-ID: <40203296-7f31-16c7-bebb-e1f1cd478a19@redhat.com> (raw)
In-Reply-To: <20200623084132.36213-1-namit@vmware.com>
On 23/06/2020 10.41, Nadav Amit wrote:
> Currently, the BSP's segment selectors are not initialized in 32-bit
> (cstart.S). As a result the tests implicitly rely on the segment
> selector values that are set by the BIOS. If this assumption is not
> kept, the task-switch test fails.
>
> Fix it by initializing them.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> x86/cstart.S | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
I'm sorry to be the bearer of bad news again, but this commit broke
another set of tests in the Travis CI:
https://travis-ci.com/github/huth/kvm-unit-tests/jobs/353103187#L796
smptest, smptest3, kvmclock_test, hyperv_synic and hyperv_stimer are
failing now in the 32-bit kvm-unit-tests :-(
Thomas
next prev parent reply other threads:[~2020-06-24 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:41 [kvm-unit-tests PATCH] x86: Initialize segment selectors Nadav Amit
2020-06-23 18:28 ` Jim Mattson
2020-06-24 6:42 ` Paolo Bonzini
2020-06-24 12:52 ` Thomas Huth [this message]
2020-06-24 14:10 ` Paolo Bonzini
2020-06-24 17:28 ` Nadav Amit
2020-06-25 7:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40203296-7f31-16c7-bebb-e1f1cd478a19@redhat.com \
--to=thuth@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@vmware.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox