From: Paolo Bonzini <pbonzini@redhat.com>
To: Liran Alon <liran.alon@oracle.com>, chao.gao@intel.com
Cc: rkrcmar@redhat.com, kvm@vger.kernel.org
Subject: Re: [kvm-unit-t)ests PATCH] kvm-unit-tests: vmx: add a test for injecting events to halted L2
Date: Wed, 14 Feb 2018 12:47:58 +0100 [thread overview]
Message-ID: <40d1a0b0-2dad-1c29-6667-63a6a983cd3c@redhat.com> (raw)
In-Reply-To: <a7d9cfdd-c0df-44d0-a40f-f30c5b3253a3@default>
On 11/02/2018 10:01, Liran Alon wrote:
>> @@ -1615,6 +1621,12 @@ static int interrupt_exit_handler(void)
>> case 6:
>> vmcs_write(GUEST_ACTV_STATE, ACTV_HLT);
>> break;
>> +
>> + case 8:
>> + vmcs_write(GUEST_ACTV_STATE, ACTV_HLT);
>> + vmcs_write(ENT_INTR_INFO,
>> + TIMER_VECTOR | INTR_INFO_VALID_MASK);
>
> I would specify interrupt-type explicitly rather than implicitly.
> Meaning passing here:
> (TIMER_VECTOR |
> (VMX_INTR_TYPE_EXT_INTR << INTR_INFO_INTR_TYPE_SHIFT) |
> INTR_INFO_VALID_MASK)
Agreed. Thanks for the review!
Paolo
>> + break;
>> }
>> vmx_inc_test_stage();
>> vmcs_write(GUEST_RIP, guest_rip + insn_len);
>> --
>> 1.9.1
>
> Besides small comment above, looks good to me.
> Reviewed-by: Liran Alon <liran.alon@oracle.com>
>
prev parent reply other threads:[~2018-02-14 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 9:01 [kvm-unit-t)ests PATCH] kvm-unit-tests: vmx: add a test for injecting events to halted L2 Liran Alon
2018-02-13 14:39 ` Paolo Bonzini
2018-02-14 11:47 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40d1a0b0-2dad-1c29-6667-63a6a983cd3c@redhat.com \
--to=pbonzini@redhat.com \
--cc=chao.gao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).