public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ozawa Tsuyoshi <ozadev@t-oza.net>
To: kvm@vger.kernel.org
Subject: [qemu-kvm][PATCH] Add "sda" alias options to "hda" options
Date: Mon, 7 Sep 2009 23:00:41 +0900	[thread overview]
Message-ID: <411a180c0909070700m2d893e7fx748f801fff762cb@mail.gmail.com> (raw)

qemu-kvm: Add "sda" alias options to "hda" options

I know that the name "hda" come from IDE drive, but I felt strange
when I use qemu to boot linux kernel directly as follows:

$ qemu-system-x86 -kernel vmlinux-2.6.28.15 -initrd
initrd.img-2.6.28.15 -hda vdisk.img

By applying this patch,  the command will change to:

$ qemu-system-x86 -kernel vmlinux-2.6.28.15 -initrd
initrd.img-2.6.28.15 -sda vdisk.img

The latter one seems to be more intuitive for me.

diff --git a/qemu-options.hx b/qemu-options.hx
index c1ec976..91cd931 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -68,6 +68,13 @@ Use @var{file} as floppy disk 0/1 image
(@pxref{disk_images}). You can
 use the host floppy by using @file{/dev/fd0} as filename (@pxref{host_drives}).
 ETEXI

+DEF("sda", HAS_ARG, QEMU_OPTION_sda,
+    "-sda/-sdb file  use 'file' as IDE hard disk 0/1 image\n")
+DEF("sdb", HAS_ARG, QEMU_OPTION_sdb, "")
+DEF("sdc", HAS_ARG, QEMU_OPTION_sdc,
+    "-sdc/-sdd file  use 'file' as IDE hard disk 2/3 image\n")
+DEF("sdd", HAS_ARG, QEMU_OPTION_sdd, "")
+
 DEF("hda", HAS_ARG, QEMU_OPTION_hda,
     "-hda/-hdb file  use 'file' as IDE hard disk 0/1 image\n")
 DEF("hdb", HAS_ARG, QEMU_OPTION_hdb, "")
diff --git a/vl.c b/vl.c
index 3485ce6..62d1d91 100644
--- a/vl.c
+++ b/vl.c
@@ -5085,6 +5085,7 @@ int main(int argc, char **argv, char **envp)
                 initrd_filename = optarg;
                 break;
             case QEMU_OPTION_hda:
+            case QEMU_OPTION_sda:
                 if (cyls == 0)
                     hda_opts = drive_add(optarg, HD_ALIAS, 0);
                 else
@@ -5096,6 +5097,9 @@ int main(int argc, char **argv, char **envp)
                              translation == BIOS_ATA_TRANSLATION_NONE ?
                                  ",trans=none" : "");
                  break;
+            case QEMU_OPTION_sdb:
+            case QEMU_OPTION_sdc:
+            case QEMU_OPTION_sdd:
             case QEMU_OPTION_hdb:
             case QEMU_OPTION_hdc:
             case QEMU_OPTION_hdd:
-- 
Tsuyoshi Ozawa
<ozawa@t-oza.net>

             reply	other threads:[~2009-09-07 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 14:00 Ozawa Tsuyoshi [this message]
2009-09-08  7:26 ` [qemu-kvm][PATCH] Add "sda" alias options to "hda" options Avi Kivity
2009-09-08 10:37   ` Tsuyoshi Ozawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=411a180c0909070700m2d893e7fx748f801fff762cb@mail.gmail.com \
    --to=ozadev@t-oza.net \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox