From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FC1C433DF for ; Mon, 17 Aug 2020 09:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B4EE206C0 for ; Mon, 17 Aug 2020 09:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbgHQJxM (ORCPT ); Mon, 17 Aug 2020 05:53:12 -0400 Received: from foss.arm.com ([217.140.110.172]:52352 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726575AbgHQJxM (ORCPT ); Mon, 17 Aug 2020 05:53:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7054031B; Mon, 17 Aug 2020 02:53:11 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EC453F66B; Mon, 17 Aug 2020 02:53:09 -0700 (PDT) Subject: Re: [PATCH 3/3] KVM: arm64: Use kvm_write_guest_lock when init stolen time To: Keqian Zhu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: Marc Zyngier , Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , wanghaibin.wang@huawei.com References: <20200817033729.10848-1-zhukeqian1@huawei.com> <20200817033729.10848-4-zhukeqian1@huawei.com> From: Steven Price Message-ID: <41523036-7492-d554-e256-32f42959684d@arm.com> Date: Mon, 17 Aug 2020 10:53:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200817033729.10848-4-zhukeqian1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 17/08/2020 04:37, Keqian Zhu wrote: > There is a lock version kvm_write_guest. Use it to simplify code. > > Signed-off-by: Keqian Zhu Reviewed-by: Steven Price > --- > arch/arm64/kvm/pvtime.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/pvtime.c b/arch/arm64/kvm/pvtime.c > index f7b52ce..2b24e7f 100644 > --- a/arch/arm64/kvm/pvtime.c > +++ b/arch/arm64/kvm/pvtime.c > @@ -55,7 +55,6 @@ gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu) > struct pvclock_vcpu_stolen_time init_values = {}; > struct kvm *kvm = vcpu->kvm; > u64 base = vcpu->arch.steal.base; > - int idx; > > if (base == GPA_INVALID) > return base; > @@ -66,10 +65,7 @@ gpa_t kvm_init_stolen_time(struct kvm_vcpu *vcpu) > */ > vcpu->arch.steal.steal = 0; > vcpu->arch.steal.last_steal = current->sched_info.run_delay; > - > - idx = srcu_read_lock(&kvm->srcu); > - kvm_write_guest(kvm, base, &init_values, sizeof(init_values)); > - srcu_read_unlock(&kvm->srcu, idx); > + kvm_write_guest_lock(kvm, base, &init_values, sizeof(init_values)); > > return base; > } >