From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/6] kvm: x86: drop read_tsc_offset()
Date: Mon, 19 Sep 2016 17:34:28 +0200
Message-ID: <41e7b724-07dd-9c9d-3119-c12e50adbe44@redhat.com>
References: <1474036056-21270-1-git-send-email-lcapitulino@redhat.com>
 <1474036056-21270-3-git-send-email-lcapitulino@redhat.com>
 <CALMp9eQPifCXi-gDEfHciCBHoEfQ34WUGud-K2T-HHuEGFNuCg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="BwSeBlsBKSFBJQOOjdqhcgv7Ceq8xxOuF"
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        rostedt@goodmis.org, mhiramat@kernel.org, mtosatti@redhat.com
To: Jim Mattson <jmattson@google.com>,
        Luiz Capitulino <lcapitulino@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CALMp9eQPifCXi-gDEfHciCBHoEfQ34WUGud-K2T-HHuEGFNuCg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--BwSeBlsBKSFBJQOOjdqhcgv7Ceq8xxOuF
Content-Type: multipart/mixed; boundary="llGP1SSrboIKbuTWJXgTGnDWcfqtbXXVt";
 protected-headers="v1"
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>,
 Luiz Capitulino <lcapitulino@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
 =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>, rostedt@goodmis.org,
 mhiramat@kernel.org, mtosatti@redhat.com
Message-ID: <41e7b724-07dd-9c9d-3119-c12e50adbe44@redhat.com>
Subject: Re: [PATCH 2/6] kvm: x86: drop read_tsc_offset()
References: <1474036056-21270-1-git-send-email-lcapitulino@redhat.com>
 <1474036056-21270-3-git-send-email-lcapitulino@redhat.com>
 <CALMp9eQPifCXi-gDEfHciCBHoEfQ34WUGud-K2T-HHuEGFNuCg@mail.gmail.com>
In-Reply-To: <CALMp9eQPifCXi-gDEfHciCBHoEfQ34WUGud-K2T-HHuEGFNuCg@mail.gmail.com>

--llGP1SSrboIKbuTWJXgTGnDWcfqtbXXVt
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable



On 19/09/2016 17:30, Jim Mattson wrote:
> vmx_read_tsc_offset has a bug when running nested VMs.  It should reall=
y be:
>=20
>        if (is_guest_mode(vcpu))
>                return to_vmx(vcpu)->nested.vmcs01_tsc_offset;
>        else
>                return vmcs_read64(TSC_OFFSET);
>=20
> Perhaps a better name woulf be "vmx_get_l1_tsc_offset."

I agree, but doesn't this patch fix the bug too?

Paolo

> In any case, this does not seem consistent with vcpu->arch.tsc_offset.


--llGP1SSrboIKbuTWJXgTGnDWcfqtbXXVt--

--BwSeBlsBKSFBJQOOjdqhcgv7Ceq8xxOuF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJX4AWEAAoJEL/70l94x66DzhIIAIhRtMeZ9Ix2Xqntrd7aZUUZ
goPfTeWhx1dEKVuZ8nOf4fJwMW1fbMyLWmslHr9M+dT0fuKvIMUqUxxmgEAuK9Am
JrPWUe5TFwQP0M0N8pkknLOpylpvmPpXeZLYWdfvUfbiHDb0BTQvBzVChjJXiX3k
wcXAKVoMReLJmC0CexmCCyXTE4ie+9XKwzkM781X1ilXxvWGSRoReokmg6Imh3Ec
Qu7r0TXCUJDgMJbzfhIb2aGpFV93Y3QrMImtUaGL5hW4iI5q3EUVjW9KYH/S26KG
9FARZnuzzIlt63bDSMIXbjv4Ir890YYyHny8MoZJERP4E789uk/BpRdxV5jSCwY=
=5H0N
-----END PGP SIGNATURE-----

--BwSeBlsBKSFBJQOOjdqhcgv7Ceq8xxOuF--