From: Niklas Schnelle <schnelle@linux.ibm.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>,
"Alex Williamson" <alex@shazbot.org>,
intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <skolothumtho@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 2/2] vfio/xe: Add a missing vfio_pci_core_release_dev()
Date: Thu, 09 Apr 2026 11:05:28 +0200 [thread overview]
Message-ID: <4209c401c7a0458ec2e5bbfccabf234ceb1eb11a.camel@linux.ibm.com> (raw)
In-Reply-To: <20260408160340.866784-2-michal.winiarski@intel.com>
On Wed, 2026-04-08 at 18:03 +0200, Michał Winiarski wrote:
> The driver is implementing its own .release(), which means that it needs
> to call vfio_pci_core_release_dev().
> Add the missing call.
>
> Reported-by: Niklas Schnelle <schnelle@linux.ibm.com>
> Closes: https://lore.kernel.org/kvm/408e262c507e8fd628a71e39904fedd99fa0ee8e.camel@linux.ibm.com/
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
> drivers/vfio/pci/xe/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c
> index 40ea73234dcf2..af95a011ed111 100644
> --- a/drivers/vfio/pci/xe/main.c
> +++ b/drivers/vfio/pci/xe/main.c
> @@ -528,6 +528,7 @@ static void xe_vfio_pci_release_dev(struct vfio_device *core_vdev)
> container_of(core_vdev, struct xe_vfio_pci_core_device, core_device.vdev);
>
> xe_vfio_pci_migration_fini(xe_vdev);
> + vfio_pci_core_release_dev(core_vdev);
> }
>
> static const struct vfio_device_ops xe_vfio_pci_ops = {
Thanks for picking this up! Feel free to add my:
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
next prev parent reply other threads:[~2026-04-09 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 16:03 [PATCH 1/2] vfio/xe: Reorganize the init to decouple migration from reset Michał Winiarski
2026-04-08 16:03 ` [PATCH 2/2] vfio/xe: Add a missing vfio_pci_core_release_dev() Michał Winiarski
2026-04-09 9:05 ` Niklas Schnelle [this message]
2026-04-09 9:28 ` Tian, Kevin
2026-04-09 9:28 ` [PATCH 1/2] vfio/xe: Reorganize the init to decouple migration from reset Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4209c401c7a0458ec2e5bbfccabf234ceb1eb11a.camel@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=skolothumtho@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox