From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: sashiko-reviews@lists.linux.dev, Farhan Ali <alifm@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH v4 6/6] KVM: s390: pci: Validate AIBV and AISB before pinning guest pages
Date: Thu, 23 Jul 2026 13:57:18 +0200 [thread overview]
Message-ID: <4219916e-4f28-44d2-80e1-b8422555d200@linux.ibm.com> (raw)
In-Reply-To: <20260722172651.848261F000E9@smtp.kernel.org>
Am 22.07.26 um 19:26 schrieb sashiko-bot@kernel.org:
> oes this size calculation artificially inflate the required AIBV memory space
> and falsely reject valid guest configurations?
>
> If a guest places a 1-MSI vector AIBV near the end of a physical page, such
> as at page offset 4088, the size formula calculates at least 9 bytes (8
> bytes from BITS_TO_LONGS(1) plus 1 arbitrary byte).
Farhan, I think this is indeed a problem.
Would
- size += (fib->fmt0.aibvo / 8) + 1; │
+ size += (fib->fmt0.aibvo / 8);
be the correct solution? BITS_TO_LONGS already rounds up I think.
next prev parent reply other threads:[~2026-07-23 11:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 17:06 [PATCH v4 0/6] KVM s390x PCI fixes Farhan Ali
2026-07-22 17:06 ` [PATCH v4 1/6] KVM: s390: pci: Reject adapter interrupt forwarding if already enabled Farhan Ali
2026-07-22 17:25 ` sashiko-bot
2026-07-23 6:57 ` Christian Borntraeger
2026-07-23 14:11 ` Matthew Rosato
2026-07-22 17:06 ` [PATCH v4 2/6] KVM: s390: pci: Fix memory accounting for pinned/unpinned pages Farhan Ali
2026-07-22 17:21 ` sashiko-bot
2026-07-23 12:08 ` Christian Borntraeger
2026-07-23 14:12 ` Matthew Rosato
2026-07-23 17:08 ` Farhan Ali
2026-07-23 17:31 ` Matthew Rosato
2026-07-22 17:06 ` [PATCH v4 3/6] KVM: s390: pci: Fix missing error codes and memory unaccounting Farhan Ali
2026-07-22 17:17 ` sashiko-bot
2026-07-23 7:34 ` Christian Borntraeger
2026-07-23 14:15 ` Matthew Rosato
2026-07-22 17:06 ` [PATCH v4 4/6] KVM: s390: pci: Fix NULL dereference on AIBV allocation failure Farhan Ali
2026-07-22 17:19 ` sashiko-bot
2026-07-23 8:18 ` Christian Borntraeger
2026-07-23 14:20 ` Matthew Rosato
2026-07-22 17:06 ` [PATCH v4 5/6] KVM: s390: pci: Fix resource leak on IRQ registration failure Farhan Ali
2026-07-22 17:15 ` sashiko-bot
2026-07-23 12:17 ` Christian Borntraeger
2026-07-23 15:19 ` Matthew Rosato
2026-07-23 16:55 ` Farhan Ali
2026-07-22 17:06 ` [PATCH v4 6/6] KVM: s390: pci: Validate AIBV and AISB before pinning guest pages Farhan Ali
2026-07-22 17:26 ` sashiko-bot
2026-07-23 11:57 ` Christian Borntraeger [this message]
2026-07-23 16:44 ` Farhan Ali
2026-07-23 12:19 ` Christian Borntraeger
2026-07-23 15:35 ` Matthew Rosato
2026-07-23 12:59 ` [PATCH v4 0/6] KVM s390x PCI fixes Christian Borntraeger
2026-07-23 13:00 ` Matthew Rosato
2026-07-23 15:35 ` Matthew Rosato
2026-07-23 16:38 ` Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4219916e-4f28-44d2-80e1-b8422555d200@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox