Re: [PATCH 0/7] tools/kvm_stat: add logfile support

Paolo Bonzini
2020-03-24T10:32:14Z

On 24/03/20 09:26, Stefan Raspl wrote:
> To be able to make use of the logfiles, we'd need to have the heading appear at
> the top of each of the files.
> Couldn't find much info on how logrotate works internally, but from what I
> gathered, it seems it moves out the current logfile e.g. /var/log/kvm.log to
> become /var/log/kvm.log.1, and sends a SIGHUP to kvm_stat so that it re-opens
> /var/log/kvm.log - which would then start out with a header again.
> That should work, but can you confirm that this is what you're suggesting?
> If so: Keep the current semantics for the original logging mode, where we have
> the heading printed every 20 lines? I would assume so, as that format is better
> suited for console logs, but just in case you wanted that changed...

Yes to all. :)

Paolo