Re: [PATCH] Enhance libkvm Makefile

[Anthony Liguori <aliguori-NZpS4cJIG2HvQtjrzfazuQ@public.gmane.org>]

Avi Kivity wrote:
> Anthony Liguori wrote:
>> diff -r ca0347086805 Makefile
>> --- a/Makefile	Thu Nov 02 18:59:50 2006 -0600
>> +++ b/Makefile	Thu Nov 02 19:00:05 2006 -0600
>> @@ -1,12 +1,11 @@
>>  
>> -KERNELDIR = ../kernel
>> +KERNELDIR ?= ../kernel
>> +PREFIX ?= /usr/local
>>   
> 
> I dislike '?=' since it makes a simple 'make' depend on environment 
> variables, so a build can have different results depending on which 
> xterm you happen to be in.
> 
> A regular assignment can be overridden on the make command line, but 
> that's somewhat tedious.  I think a simple ./configure (NOT the 
> autotools thing) is best.

It's a bit late here but I'll take a look at the build tomorrow. 
Personally, I like to avoid autoconf like the plague so I'm happy with a 
  simple configure script :-)

Regards,

Anthony Liguori

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642