From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Enhance libkvm Makefile Date: Fri, 03 Nov 2006 00:41:54 -0600 Message-ID: <454AE4B2.3050606@cs.utexas.edu> References: <454A9578.1080100@cs.utexas.edu> <454ADCE9.7000505@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: To: Avi Kivity In-Reply-To: <454ADCE9.7000505-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Anthony Liguori wrote: >> diff -r ca0347086805 Makefile >> --- a/Makefile Thu Nov 02 18:59:50 2006 -0600 >> +++ b/Makefile Thu Nov 02 19:00:05 2006 -0600 >> @@ -1,12 +1,11 @@ >> >> -KERNELDIR = ../kernel >> +KERNELDIR ?= ../kernel >> +PREFIX ?= /usr/local >> > > I dislike '?=' since it makes a simple 'make' depend on environment > variables, so a build can have different results depending on which > xterm you happen to be in. > > A regular assignment can be overridden on the make command line, but > that's somewhat tedious. I think a simple ./configure (NOT the > autotools thing) is best. It's a bit late here but I'll take a look at the build tomorrow. Personally, I like to avoid autoconf like the plague so I'm happy with a simple configure script :-) Regards, Anthony Liguori ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642