From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4) Date: Wed, 08 Nov 2006 11:54:56 +0200 Message-ID: <4551A970.9090704@qumranet.com> References: <454E4941.7000108@qumranet.com> <20061107204440.090450ea.akpm@osdl.org> <455183EA.2020405@qumranet.com> <20061107233323.c984fa9b.akpm@osdl.org> <45519033.3060409@qumranet.com> <1162978754.3138.266.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Roland Dreier , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: To: Arjan van de Ven In-Reply-To: <1162978754.3138.266.camel-NIQFrBLA1CpScpXdPBN83iCwEArCW2h5@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Arjan van de Ven wrote: >>> Would >>> really prefer something at Kconfig-time, but we have no way of letting the >>> assembler version feed into the Kconfig system (nor do we want it, I >>> suspect). >>> >>> >> config AS_VERSION >> eval as --version | awk '{ ... }' >> > > > config time is not possible (not to mention it's not that uncommon to > config on a different box than you compile). If we add the 'eval' Kconfig keyword, it becomes possible, but I guess it isn't worth it if there are more users and anyway split configure/compile, as you note, breaks it. > Makefile side is not that > hard; in fact what you'd need is a very small check similar to > scripts/gcc-x86_64-has-stack-protector.sh . While that checks a gcc > feature, checking the VMX operations via a C program with inline asm is > actually the most realistic test ANYWAY ... > The problem with that is that the test comes too late: after we've configured. Andrew wants to keep allmodconfig working, and for that we need to deselect CONFIG_KVM before compilation starts. gcc.*protector.sh only affects the Makefile, not the configuration, AFAICT. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642