opaque field?

opaque field?

[Jun Koi]

hi,

in the structure kvm_context in libkvm:

struct kvm_context {
    int fd;
    struct kvm_callbacks *callbacks;
    void *opaque;
    void *physical_memory;
};

i would propose to change the field name to "private" or "data",
rather than "opaque", which is a little bit weird to me.

Jun

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: opaque field?

[Anthony Liguori]

Jun Koi wrote:
> hi,
> 
> in the structure kvm_context in libkvm:
> 
> struct kvm_context {
>     int fd;
>     struct kvm_callbacks *callbacks;
>     void *opaque;
>     void *physical_memory;
> };
> 
> i would propose to change the field name to "private" or "data",
> rather than "opaque", which is a little bit weird to me.

opaque is a pretty common name for this sort of thing.  private is a 
reserved keyword in C++ and data is about as generic as it gets.

Regards,

Anthony Liguori

> Jun
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642