From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: opaque field? Date: Thu, 09 Nov 2006 20:28:29 -0600 Message-ID: <4553E3CD.7050606@cs.utexas.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: To: Jun Koi In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jun Koi wrote: > hi, > > in the structure kvm_context in libkvm: > > struct kvm_context { > int fd; > struct kvm_callbacks *callbacks; > void *opaque; > void *physical_memory; > }; > > i would propose to change the field name to "private" or "data", > rather than "opaque", which is a little bit weird to me. opaque is a pretty common name for this sort of thing. private is a reserved keyword in C++ and data is about as generic as it gets. Regards, Anthony Liguori > Jun > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642