From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation Date: Mon, 27 Nov 2006 15:46:43 +0200 Message-ID: <456AEC43.40307@qumranet.com> References: <456AD5C6.1090406@qumranet.com> <20061127122938.0518325015E@cleopatra.q> <20061127133944.GA4155@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: To: Christoph Hellwig , Avi Kivity , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-3NddpPZAyC0@public.gmane.org In-Reply-To: <20061127133944.GA4155-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Christoph Hellwig wrote: > On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote: > >> #ifdef __x86_64__ >> - __set_efer(vcpu, sregs->efer); >> + kvm_arch_ops->set_efer(vcpu, sregs->efer); >> #endif >> > > I think it would be much better to make ->set_efer a noop for 32bit, > and have different operation vectors for 32 vs 64 bit. > > Okay. I'll submit an incremental patch as part of a larger cleanup I'm planning. >> #ifdef __x86_64__ >> - __set_efer(vcpu, 0); >> + vmx_set_efer(vcpu, 0); >> #endif >> > > Similarly vmx_set_efer should just become a noop on 32bit. > Ok. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV