From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFT] Fix for unhandled msr c0000081 problems under Intel cpus Date: Thu, 14 Dec 2006 11:22:44 +0200 Message-ID: <458117E4.4010807@qumranet.com> References: <457FCBB9.5070800@qumranet.com> <45805400.3060308@mr511.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: To: Michael Riepe In-Reply-To: <45805400.3060308-0QoEqw4nQxo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Michael Riepe wrote: > Oh well... > > I was wondering which stupid piece of sh^H^Hcode generated so many wrong > rdmsr instructions without looking at the CPU feature flags. So I > grepped through the linux kernel and glibc sources as well as some other > likely suspects and found - nothing. > > Guess what? It's qemu! > > In qemu-kvm.c (around line 329 in save_regs()) it starts to call > kvm_get_msrs(), and one of the MSRs it wants to read is MSR_STAR. When I > removed MSR_STAR from the list (which fortunately has no consequences on > my Core Duo), the messages were gone. > Yes, you're right. I'll commit the previous patch (which is correct, even if no guest actually uses syscall), and teach qemu not to read MSR_STAR when it isn't available. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV