public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Windows XP internal Power error
Date: Mon, 18 Dec 2006 11:32:19 +0200	[thread overview]
Message-ID: <45866023.6090508@qumranet.com> (raw)
In-Reply-To: <20061218093511.uycqxxmsbpoookoo-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT@public.gmane.org wrote:
> Hi, modified NR_BAD_MSRS, dmesg reports:
>

ok, please revert all patches an apply the attached.

-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: dont-munge-efer.patch --]
[-- Type: text/x-patch, Size: 1149 bytes --]

Index: vmx.c
===================================================================
--- vmx.c	(revision 4120)
+++ vmx.c	(working copy)
@@ -74,7 +74,7 @@
 #ifdef CONFIG_X86_64
 	MSR_SYSCALL_MASK, MSR_LSTAR, MSR_CSTAR, MSR_KERNEL_GS_BASE,
 #endif
-	MSR_EFER, MSR_K6_STAR,
+	MSR_K6_STAR,
 };
 #define NR_VMX_MSR (sizeof(vmx_msr_index) / sizeof(*vmx_msr_index))
 
@@ -754,7 +754,6 @@
 
 	vcpu->shadow_efer |= EFER_LMA;
 
-	find_msr_entry(vcpu, MSR_EFER)->data |= EFER_LMA | EFER_LME;
 	vmcs_write32(VM_ENTRY_CONTROLS,
 		     vmcs_read32(VM_ENTRY_CONTROLS)
 		     | VM_ENTRY_CONTROLS_IA32E_MASK);
@@ -824,22 +823,15 @@
 
 static void vmx_set_efer(struct kvm_vcpu *vcpu, u64 efer)
 {
-	struct vmx_msr_entry *msr = find_msr_entry(vcpu, MSR_EFER);
-
 	vcpu->shadow_efer = efer;
-	if (efer & EFER_LMA) {
+	if (efer & EFER_LMA)
 		vmcs_write32(VM_ENTRY_CONTROLS,
 				     vmcs_read32(VM_ENTRY_CONTROLS) |
 				     VM_ENTRY_CONTROLS_IA32E_MASK);
-		msr->data = efer;
-
-	} else {
+	else
 		vmcs_write32(VM_ENTRY_CONTROLS,
 				     vmcs_read32(VM_ENTRY_CONTROLS) &
 				     ~VM_ENTRY_CONTROLS_IA32E_MASK);
-
-		msr->data = efer & ~EFER_LME;
-	}
 }
 
 #endif

[-- Attachment #3: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  parent reply	other threads:[~2006-12-18  9:32 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-13 16:18 Windows XP internal Power error ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found] ` <20061213171800.dioo94f5ph28o84g-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-13 16:47   ` Dor Laor
     [not found]     ` <64F9B87B6B770947A9F8391472E03216097F08BA-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2006-12-14  7:12       ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]         ` <20061214081240.w465jyhcymkg4cco-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14  9:26           ` Avi Kivity
     [not found]             ` <458118D8.6040300-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-14  9:42               ` Dor Laor
     [not found]                 ` <64F9B87B6B770947A9F8391472E03216097F0C8E-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2006-12-14 10:50                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                     ` <20061214115030.5zeg7g3xl24ggwkg-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14 11:35                       ` Avi Kivity
     [not found]                         ` <45813717.7080708-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-14 12:54                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                             ` <20061214135404.f9ynqte6wqhw04gg-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14 13:41                               ` Dor Laor
     [not found]                                 ` <64F9B87B6B770947A9F8391472E03216098CC578-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2006-12-14 14:00                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                     ` <20061214150033.1rcw82d4hcys4g0w-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14 14:09                                       ` Dor Laor
     [not found]                                         ` <64F9B87B6B770947A9F8391472E03216098CC58B-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2006-12-14 14:30                                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                             ` <20061214153047.6v3a82ev5c4k8004-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14 15:20                                               ` Avi Kivity
     [not found]                                                 ` <45816BC9.2000905-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-14 15:57                                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                     ` <20061214165724.5nf6l4zl13aoswk4-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-15  5:28                                                       ` Avi Kivity
     [not found]                                                         ` <4582328B.3030501-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-15  7:06                                                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                             ` <20061215080629.ym6lnw1soydc044k-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-15 12:49                                                               ` Michael Riepe
     [not found]                                                                 ` <458299BC.7020209-0QoEqw4nQxo@public.gmane.org>
2006-12-16  7:19                                                                   ` Avi Kivity
2006-12-16  7:14                                                               ` Avi Kivity
     [not found]                                                                 ` <45839CD6.3080903-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-18  7:32                                                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                     ` <20061218083243.s7o07wy9mvwwgg4o-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-18  8:21                                                                       ` Avi Kivity
     [not found]                                                                         ` <45864F9B.1070808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-18  8:35                                                                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                             ` <20061218093511.uycqxxmsbpoookoo-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-18  9:32                                                                               ` Avi Kivity [this message]
     [not found]                                                                                 ` <45866023.6090508-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-18 10:54                                                                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                                     ` <20061218115403.7wjpmj5gbs9oggck-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-19 10:34                                                                                       ` Avi Kivity
     [not found]                                                                                         ` <4587C036.1080803-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-19 10:54                                                                                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                                             ` <20061219115452.gnmw21wnuq3ososs-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-19 11:01                                                                                               ` Avi Kivity
     [not found]                                                                                                 ` <4587C678.5030803-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-19 11:15                                                                                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                                                     ` <20061219121529.7ta9qlrrc6mww8k0-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-19 11:28                                                                                                       ` Avi Kivity
     [not found]                                                                                                         ` <4587CCF5.10908-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-19 12:49                                                                                                           ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                                                             ` <20061219134908.woim5pthdpwgcw4g-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-19 13:17                                                                                                               ` Avi Kivity
     [not found]                                                                                                                 ` <4587E650.3050300-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-19 13:23                                                                                                                   ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                                                                                                                 ` <20061219142348.gu7egvvgctck8csk@webmail.provincia.torino .it>
     [not found]                                                                                                                   ` <20061219142348.gu7egvvgctck8csk-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-19 13:28                                                                                                                     ` Avi Kivity
2006-12-19 12:46                                                                                                     ` Uri Lublin
     [not found]                                                                                                       ` <64F9B87B6B770947A9F8391472E0321603496AEE-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2006-12-19 13:05                                                                                                         ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
2006-12-19 13:50                                                                                                           ` Uri Lublin
2006-12-19 11:01                                                                                               ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
2006-12-14 10:32               ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT
     [not found]                 ` <20061214113244.bmhvaz6ysk084o84-2RFepEojUI1V4YG60fcVpWnFp5FU0k5wNRkNT7W+5VM@public.gmane.org>
2006-12-14 10:37                   ` Avi Kivity
2006-12-26 14:58           ` Avi Kivity
     [not found]             ` <45913893.8020109-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2006-12-28  9:10               ` ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45866023.6090508@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=ignazio.cassano-VeGButH3FaVpxaeRVNJOcDUZDU+1vuVT@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox