From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] kvm: fix GFP_KERNEL alloc in atomic section bug Date: Thu, 28 Dec 2006 14:44:10 +0200 Message-ID: <4593BC1A.9080503@qumranet.com> References: <458A57A4.9000807@qumranet.com> <20061228123219.GA27387@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, linux-kernel , Andrew Morton , Linus Torvalds Return-path: To: Ingo Molnar In-Reply-To: <20061228123219.GA27387@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > Subject: [patch] kvm: fix GFP_KERNEL alloc in atomic section bug > From: Ingo Molnar > > KVM does kmalloc() in an atomic section while having preemption disabled > via vcpu_load(). Fix this by moving the ->*_msr setup from the > vcpu_setup method to the vcpu_create method. > > (This is also a small speedup for setting up a vcpu, which can in theory > be more frequent than the vcpu_create method). > > Signed-off-by: Ingo Molnar > Applied, thanks. -- error compiling committee.c: too many arguments to function