From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() Date: Thu, 28 Dec 2006 15:14:45 +0200 Message-ID: <4593C345.9040306@qumranet.com> References: <45939755.7010603@qumranet.com> <20061228124224.GA28573@elte.hu> <4593BEE6.30206@qumranet.com> <20061228125544.GA31207@elte.hu> <20061228130833.GA555@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , linux-kernel , Andrew Morton , Linus Torvalds Return-path: To: Ingo Molnar In-Reply-To: <20061228130833.GA555@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > Subject: [patch] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() > From: Ingo Molnar > > fix an GFP_KERNEL allocation in atomic section: > kvm_dev_ioctl_create_vcpu() called kvm_mmu_init(), which calls > alloc_pages(), while holding the vcpu. > > The fix is to set up the MMU state in two phases: kvm_mmu_create() and > kvm_mmu_setup(). > > (NOTE: free_vcpus does an kvm_mmu_destroy() call so there's no need > for any extra teardown branch on allocation/init failure here.) > > Signed-off-by: Ingo Molnar > Applied, thanks. -- error compiling committee.c: too many arguments to function