From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: initialize kvm_arch_ops in kvm_init() Date: Thu, 28 Dec 2006 15:44:00 +0200 Message-ID: <4593CA20.9060908@qumranet.com> References: <86C728BB73C10Bichiyanagi.yoshimi@lab.ntt.co.jp> <4590E0DE.7030808@qumranet.com> <8FC72A6E4061FDichiyanagi.yoshimi@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, moriai.satoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org, kihara.seiji-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org Return-path: To: Yoshimi Ichiyanagi In-Reply-To: <8FC72A6E4061FDichiyanagi.yoshimi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Yoshimi Ichiyanagi wrote: >> This bit is unnecessary, no? I think kvm_init() will only be called >> after the module is loaded, at which point kvm_arch_ops is initialized >> > >from the .bss section. > > > Logically it's not required, however it's better to initialize > explicitly in general. > > Personally I agree, but Linux coding style does not. > By the way, the previous patch didn't fix the problem completely. > You can't load the supported arch's module > if you load the unsupported arch's module beforehand. > > The following patch will fix this problem. > Please take a look. > Applied, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV