From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/8] KVM: Implement a few system configuration msrs Date: Mon, 01 Jan 2007 10:20:53 +0200 Message-ID: <4598C465.5070308@qumranet.com> References: <45939755.7010603@qumranet.com> <20061228101117.65A392500F7@il.qumranet.com> <200701010107.18008.ioe-lkml@rameria.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, akpm-3NddpPZAyC0@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: To: Ingo Oeser In-Reply-To: <200701010107.18008.ioe-lkml-MFZNYGWX9eyELgA04lAiVw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Oeser wrote: > Hi, > > On Thursday, 28. December 2006 11:11, Avi Kivity wrote: > >> Index: linux-2.6/drivers/kvm/svm.c >> =================================================================== >> --- linux-2.6.orig/drivers/kvm/svm.c >> +++ linux-2.6/drivers/kvm/svm.c >> @@ -1068,6 +1068,9 @@ static int emulate_on_interception(struc >> static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data) >> { >> switch (ecx) { >> + case 0xc0010010: /* SYSCFG */ >> + case 0xc0010015: /* HWCR */ >> + case MSR_IA32_PLATFORM_ID: >> case MSR_IA32_P5_MC_ADDR: >> case MSR_IA32_P5_MC_TYPE: >> case MSR_IA32_MC0_CTL: >> > > What about just defining constants for these? > Then you can rip out these comments. > > Same for linux-2.6/drivers/kvm/vmx.c > Yes, there are a few more of these as well. I'll clean them up once things quiet down a bit. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV