From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] kvm: make cr3 loading more robust Date: Wed, 03 Jan 2007 14:29:08 +0200 Message-ID: <459BA194.8070305@qumranet.com> References: <20070103021057.GA11316@elte.hu> <459B695C.5090004@qumranet.com> <20070103115911.GA2786@elte.hu> <459B9C5C.9060008@qumranet.com> <20070103122114.GD2786@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel Return-path: To: Ingo Molnar In-Reply-To: <20070103122114.GD2786-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > >> The context switch paths need to do the same. >> > > yeah. Although, as this example has shown it, such implicit assumptions > carried into code tends to be volatile. Couldnt the kvm_mmu_zap_page() > be done implicitly within kvm_mmu_alloc_page()? As long as the list is > LRU, and the number of allocations done within a logical operation > doesnt exceed the size of the LRU list (which it doesnt), this should be > doable. > Right not the list is not LRU, so a zap can kill your parent page table. I'm also worried about preserving invariants, as the page tables are linked through a variety of data structures. Calling zap_page() while another operation is in progress could cause corruption if zap_page() kills one of your parents or children. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV