Re: [PATCH] kvm-12 userland guest reboot fix

Avi Kivity
2007-01-24T15:14:34Z

Joerg Roedel wrote:
> On Wed, Jan 24, 2007 at 03:47:58PM +0200, Avi Kivity wrote:
>
>> Joerg Roedel wrote:
>>
>>> From: Markus Rechberger <markus.rechberger-5C7GfCeVMHo@public.gmane.org>
>>> From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
>>>
>>> This patch fixes the initialization of the segment registers which
>>> solves the triple fault and keyboard controller reset problems in
>>> kvm/qemu guests as well as the slow grub menu interaction. This works
>>> for SVM now, it is not tested on kvm/vmx.
>>>
>>>
>>>
>> The patch fails to boot on Intel hosts. Most likely the segment
>> changes are illegal for vm86 mode, which we use on Intel to simulate
>> real mode.
>>
>> I tried to change flags in cpu_reset() so that type == 3 and dpl == 3,
>> as required by 22.3.1.2, but it didn't help.
>>
>
> Hmm, I am not aware of the VMX and realmode emulation implementation. Is
> it hard to simply hide those flags to the vm86 mode?
>
>

It is supposed to be hidden (see fix_rmode_seg(), called from
enter_rmode()), but somehow that path fails.

It's been a while since I hacked on that code.

--
error compiling committee.c: too many arguments to function