From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Oops after resume from suspend Date: Fri, 26 Jan 2007 20:12:16 +0200 Message-ID: <45BA4480.40203@qumranet.com> References: <1169676112.10817.13.camel@aglarond.local> <45B86338.8050306@qumranet.com> <45B90E61.2090304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jeremy Katz Return-path: In-Reply-To: <45B90E61.2090304-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jeremy Katz wrote: > Avi Kivity wrote: >> Jeremy Katz wrote: >>> When using kvm on my laptop, I get the following oops if I try using >>> kvm >>> after a suspend (ACPI S3)/resume cycle. At first I thought it went >>> away >>> if I unloaded the module before suspending and then reloading it >>> afterwards, but I can't reproduce that working now, so I might have >>> just >>> been hallucinating. Thoughts of things to try? >> >> Module unload/reload should work. Can you try adding printks in >> hardware_disable() and hardware_enable()? > > Okay, what was going wrong with reloading was the difference between - > and _ with module naming :-/ *sigh* Actually getting the module > unloaded then makes things work fine. I was bitten by this too... > >> For real suspend support, we need to flush any cached state on Intel >> cpus (vmcs_clear), and to do the hardware_disable()/hardware_enable() >> cycle. Should be easy. > > The obvious approach (attached) fails to resume -- there may be > console output, but hard to tell on my laptop. I'll dig up a box with > a serial port to try there and see if I get something across serial > console with it. It also needs cpu hotplug support, and some work to decache the vmcs on Intel hosts. I have this three-quarters working now. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV