Re: [PATCH] simplify pdpte check

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Muli Ben-Yehuda wrote:
> Small cleanup: we check (pdpte & 1) && (pdpte & constant). Instead
> just check (pdpte & (constant | 1)).
>
> Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
>
> Index: kernel/kvm_main.c
> ===================================================================
> --- kernel/kvm_main.c	(revision 4379)
> +++ kernel/kvm_main.c	(working copy)
> @@ -336,7 +336,7 @@
>  	ret = 1;
>  	for (i = 0; i < 4; ++i) {
>  		pdpte = pdpt[offset + i];
> -		if ((pdpte & 1) && (pdpte & 0xfffffff0000001e6ull)) {
> +		if (pdpte & 0xfffffff0000001e7ull) {
>  			ret = 0;
>  			goto out;
>  		}
>
>   

The code is not equivalent.  For example, pdpte == 2 passes the check 
before the patch and fails it after.



-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642