Re: [PATCH] kvm compat patch

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Markus Rechberger wrote:
> This patch fixes the mutex, page and kzalloc problems with older kernels.
>
> Signed-off-by: Markus Rechberger <markus.rechberger-5C7GfCeVMHo@public.gmane.org>
>
>   

The page_private() and kzalloc() stuff looks good, I can apply it.  But:

> Index: kvm.h
> ===================================================================
> --- kvm.h	(revision 4381)
> +++ kvm.h	(working copy)
> @@ -8,7 +8,9 @@
>  
>  #include <linux/types.h>
>  #include <linux/list.h>
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
>  #include <linux/mutex.h>
> +#endif
>   

Checks on kernel version are (usually) not accepted in mainline.  I 
think I can cook up some Makefile magic to work around the #include though.


>  #include <linux/spinlock.h>
>  #include <linux/mm.h>
>  
> @@ -225,7 +227,11 @@
>  		struct vmcs *vmcs;
>  		struct vcpu_svm *svm;
>  	};
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
>  	struct mutex mutex;
> +#else
> +	struct semaphore mutex;
> +#endif
>   

'#define mutex semaphore' in external-module-comapt.h, please.

> +#if 0
> +	page->private;
> +#endif
>   

Please delete.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642