Re: [PATCH] check for KVM_GET/SET_REG ioctl failures

[Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

Muli Ben-Yehuda wrote:
> On Tue, Feb 06, 2007 at 01:26:56PM -0600, Anthony Liguori wrote:
>
>   
>> Please don't add exit()'s to a library, these are the sort of things
>> we should be trying to remove.
>>     
>
> I agree on general principles, but do we envision libkvm.a being used
> in anything outside qemu? in any case, if not exit(), what would you
> suggest? from a quick reading of the code, it doesn't appear feasible
> to go on when get or set regs fail.
>   

Propagate it up and let QEMU decide what to do.

There is at least one other user of libkvmctl that I know of.

>> In the very least, you should probably expect to see EINTRs.
>>     
>
> Hmm, which code path do you have in mind that can return EINTR here?
>   

QEMU uses signals quite a bit so I think being defensive on syscalls is 
best.  It's stung me a few times.

I don't think that the {GET,SEG}_REGS ioctls would actually return EINTR 
ATM.

Regards,

Anthony Liguori

> Cheers,
> Muli
>   


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642