From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] check for KVM_GET/SET_REG ioctl failures Date: Tue, 06 Feb 2007 14:59:48 -0600 Message-ID: <45C8EC44.509@us.ibm.com> References: <20070206184639.GA4292@rhun.ibm.com> <45C8D680.3020704@us.ibm.com> <20070206193939.GE4292@rhun.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Muli Ben-Yehuda Return-path: In-Reply-To: <20070206193939.GE4292-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Muli Ben-Yehuda wrote: > On Tue, Feb 06, 2007 at 01:26:56PM -0600, Anthony Liguori wrote: > > >> Please don't add exit()'s to a library, these are the sort of things >> we should be trying to remove. >> > > I agree on general principles, but do we envision libkvm.a being used > in anything outside qemu? in any case, if not exit(), what would you > suggest? from a quick reading of the code, it doesn't appear feasible > to go on when get or set regs fail. > Propagate it up and let QEMU decide what to do. There is at least one other user of libkvmctl that I know of. >> In the very least, you should probably expect to see EINTRs. >> > > Hmm, which code path do you have in mind that can return EINTR here? > QEMU uses signals quite a bit so I think being defensive on syscalls is best. It's stung me a few times. I don't think that the {GET,SEG}_REGS ioctls would actually return EINTR ATM. Regards, Anthony Liguori > Cheers, > Muli > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642