From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] check for KVM_GET/SET_REG ioctl failures Date: Tue, 06 Feb 2007 15:20:37 -0600 Message-ID: <45C8F125.3010801@us.ibm.com> References: <20070206184639.GA4292@rhun.ibm.com> <45C8D680.3020704@us.ibm.com> <20070206193939.GE4292@rhun.ibm.com> <45C8EC44.509@us.ibm.com> <20070206210926.GI4292@rhun.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Muli Ben-Yehuda Return-path: In-Reply-To: <20070206210926.GI4292-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Muli Ben-Yehuda wrote: > On Tue, Feb 06, 2007 at 02:59:48PM -0600, Anthony Liguori wrote: > > >> Propagate it up and let QEMU decide what to do. >> >> There is at least one other user of libkvmctl that I know of. >> > > Ok, I'll rework it this way (and fix the rest of exit()'s in libkvm > while I'm at it). Do we agree the right thing for qemu to do on ioctl > failures at this time is exit()? > I don't think it's the best thing, but it's acceptable IMHO. Regards, Anthony Liguori >> QEMU uses signals quite a bit so I think being defensive on syscalls >> is best. It's stung me a few times. >> > > Syscalls don't return EINTR unless they're written specifically to > check for sigpending() and return EINTR. I don't think there's any > point to check for EINTR here when we know that the ioctl() will never > return it. If that changes, we'll have to audit all of the callers > anyway and change them. > > Cheers, > Muli > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642