Re: [kvm-commits] kvm: revert r4386 (rev 4422)

Laurent Vivier
2007-02-14T13:31:09Z

[-- Attachment #1.1: Type: text/plain, Size: 1558 bytes --]

Avi Kivity wrote:
> Muli Ben-Yehuda wrote:
>> On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote:
>>
>>> Muli Ben-Yehuda wrote:
>>>
>>>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote:
>>>>
>>>>
>>>>> kvm: revert r4386
>>>>>
>>>>> causes breakage, as well as using evil '?=' assignment.
>>>>>
>>>>>
>>>> *sigh*, this breaks --kerneldir.
>>>>
>>>> The patch I resent early this morning does the right thing.
>>>>
>>> Well, --kerneldir should be fixed without ?= and with testing.
>>>
>> What's wrong with '?='?
>>
>
> It allows environment variables to affect the compilation.

Environment variables affect compilation, try:

# cd kvm-13
# make clean
# ./configure --prefix=/usr --with-patched-kernel
# export CC=toto
# make
make -C user
make[1]: Entering directory `/home/vivierl/kvm-13/user'
toto -I /usr/src/linux-2.6.20/include -MMD -MF ./.kvmctl.d -g -c -o kvmctl.o
kvmctl.c
make[1]: toto: Command not found
make[1]: *** [kvmctl.o] Error 127
make[1]: Leaving directory `/home/vivierl/kvm-13/user'
make: *** [user] Error 2

If you protect "KERNELDIR", perhaps you should protect "CC" too... and all other
shell variables.
IMHO, it is more flexible to allow environment to affect behaviour of commands :
it is the aim of shell variables.

Regards,
Laurent
--
------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org --------------
"Any sufficiently advanced technology is
indistinguishable from magic." - Arthur C. Clarke

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org