Re: [kvm-commits] kvm: revert r4386 (rev 4422)

Muli Ben-Yehuda
2007-02-14T08:30:39Z

On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote:
> Muli Ben-Yehuda wrote:
> >On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote:
> >
> >>kvm: revert r4386
> >>
> >>causes breakage, as well as using evil '?=' assignment.
> >>
> >
> >*sigh*, this breaks --kerneldir.
> >
> >The patch I resent early this morning does the right thing.
>
> Well, --kerneldir should be fixed without ?= and with testing.

What's wrong with '?='?

Are we requiring running `configure' in the top level before running
'make' in kernel/? if yes, getting rid of the KERNELDIR assignment in
kernel/Makefile is trivial, if not, '?=' expresses the semantics
exactly - if KERNELDIR is already set, use that, if not set it to the
default.