Re: [kvm-commits] kvm: revert r4386 (rev 4422)

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Muli Ben-Yehuda wrote:
> On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote:
>   
>> Muli Ben-Yehuda wrote:
>>     
>>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote:
>>>  
>>>       
>>>> kvm: revert r4386
>>>>
>>>> causes breakage, as well as using evil '?=' assignment.
>>>>    
>>>>         
>>> *sigh*, this breaks --kerneldir.
>>>
>>> The patch I resent early this morning does the right thing.
>>>       
>> Well, --kerneldir should be fixed without ?= and with testing.
>>     
>
> What's wrong with '?='?
>   

It allows environment variables to affect the compilation.


> Are we requiring running `configure' in the top level before running
> 'make' in kernel/? 

For now, yes.  If it's desired to have kernel/ as a standalone 
directory, it should have its own ./configure (called from the top-level 
./configure for a full build).

> if yes, getting rid of the KERNELDIR assignment in
> kernel/Makefile is trivial, if not, '?=' expresses the semantics
> exactly - if KERNELDIR is already set, use that, if not set it to the
> default.
>   

Maybe.  I'm just not up to testing 3 options x a zillion distros.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV