From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-commits] kvm: revert r4386 (rev 4422) Date: Wed, 14 Feb 2007 15:15:37 +0200 Message-ID: <45D30B79.6080807@qumranet.com> References: <20070214075713.2D6DC250354@il.qumranet.com> <20070214080623.GD461@rhun.ibm.com> <45D2C78A.4060203@qumranet.com> <20070214083039.GE461@rhun.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Muli Ben-Yehuda Return-path: In-Reply-To: <20070214083039.GE461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Muli Ben-Yehuda wrote: > On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: > >> Muli Ben-Yehuda wrote: >> >>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: >>> >>> >>>> kvm: revert r4386 >>>> >>>> causes breakage, as well as using evil '?=' assignment. >>>> >>>> >>> *sigh*, this breaks --kerneldir. >>> >>> The patch I resent early this morning does the right thing. >>> >> Well, --kerneldir should be fixed without ?= and with testing. >> > > What's wrong with '?='? > It allows environment variables to affect the compilation. > Are we requiring running `configure' in the top level before running > 'make' in kernel/? For now, yes. If it's desired to have kernel/ as a standalone directory, it should have its own ./configure (called from the top-level ./configure for a full build). > if yes, getting rid of the KERNELDIR assignment in > kernel/Makefile is trivial, if not, '?=' expresses the semantics > exactly - if KERNELDIR is already set, use that, if not set it to the > default. > Maybe. I'm just not up to testing 3 options x a zillion distros. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV